Messages in this thread | | | Date | Fri, 25 May 2007 06:03:54 +0200 | From | Pierre Ossman <> | Subject | Re: [PATCH] Make prepare_namespace() wait for devices |
| |
Andrew Morton wrote: > On Thu, 24 May 2007 14:21:35 +0200 > Pierre Ossman <drzeus-list@drzeus.cx> wrote: > > >> + /* wait for any asynchronous scanning to complete */ >> + if ((ROOT_DEV == 0) && root_wait) { >> + printk(KERN_INFO "Waiting for root device %s...\n", >> + saved_root_name); >> + do { >> + while (driver_probe_done() != 0) >> + msleep(100); >> + ROOT_DEV = name_to_dev_t(saved_root_name); >> + if (ROOT_DEV == 0) >> + msleep(100); >> + } while (ROOT_DEV == 0); >> + } >> > > This seems overly complex. Can't we simply do > > > while (driver_probe_done() || ROOT_DEV == 0) > msleep(100); > > ? >
How would ROOT_DEV get updated in that loop?
-- -- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |