lkml.org 
[lkml]   [2007]   [May]   [24]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 23 May 2007 20:59:35 -0700
FromPhil Dibowitz <>
SubjectRe: [PATCH 6/6] UNUSUAL_DEV: Sync up some reported devices from Ubuntu
Ben Collins wrote:
> Various unusual dev entries accumulated from Ubuntu bug reports.
> 
> CC: Phil Dibowitz <phil@ipom.com>

NACK. Two fixes I'd like to see fixed.

> +/* SanDisk that has a second LUN for a driver ISO, reported by
> + * Ben Collins <bcollins@ubuntu.com> */
> +UNUSUAL_DEV( 0x0781, 0x5406, 0x0000, 0xffff,

Please use specific device IDs unless you have reason to believe the range
as a whole is affected (or large portions at least)

> +/* Reported by Edward Chapman <[EMAIL PROTECTED]>
> +   Netac OnlyDisk Mini U2CV2 512MB USB 2.0 Flash Drive */
> +UNUSUAL_DEV( 0x0dd8, 0xd202, 0x0000, 0x9999,

Same here.

Thanks.
-- 
Phil Dibowitz                             phil@ipom.com
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Never write it in C if you can do it in 'awk';
 Never do it in 'awk' if 'sed' can handle it;
 Never use 'sed' when 'tr' can do the job;
 Never invoke 'tr' when 'cat' is sufficient;
 Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2007-05-24 04:23    [from the cache]
©2003-2008