lkml.org 
[lkml]   [2007]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] msi: Fix the ordering of msix irqs.
From
Date
On Thu, 2007-05-24 at 15:08 -0600, Eric W. Biederman wrote:
> Yours looks more complete then my test patch so:
>
> From: "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net> writes:
>
> Found what seems the problem with our vectors being listed backward. In
> drivers/pci/msi.c we should be using list_add_tail rather than list_add to
> preserve the ordering across various kernels. Please consider this for
> inclusion.
>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

Screwed-up-by: Michael Ellerman <michael@ellerman.id.au>

The sad part is my earlier patches did use list_add_tail(), doh. :(

Thanks for debugging it.

cheers

--
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2007-05-25 04:35    [from the cache]
©2003-2011 Jasper Spaans