Messages in this thread Patch in this message | | | Date | Thu, 24 May 2007 17:15:35 -0700 | From | Randy Dunlap <> | Subject | [PATCH] use printk.time option, drop time/notime |
| |
From: Randy Dunlap <randy.dunlap@oracle.com>
Andrew, please drop add-notime-boot-option.patch and use this patch instead...
Allow printk_time to be enabled or disabled at boot time. Previously it could be enabled only, but not disabled.
Change printk_time from an int to a bool since that's what it is. Make its logical (exposed) name just be "time" (was "printk_time").
Note: Changes kernel boot option syntax from "time" to "printk.time=value".
Since printk_time is declared as a module_param, it can also be changed at run-time by modifying /sys/module/printk/parameters/time to a value of 1/Y/y to enabled it or 0/N/n to disable it.
Since printk_time is declared as a module_param, its value can also be set at boot-time by using linux printk.time=<bool>
Drop the "time" boot option and its __setup() functions.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- Documentation/kernel-parameters.txt | 5 +++-- kernel/printk.c | 12 +----------- 2 files changed, 4 insertions(+), 13 deletions(-)
--- linux-2622-rc2g5.orig/Documentation/kernel-parameters.txt +++ linux-2622-rc2g5/Documentation/kernel-parameters.txt @@ -1406,6 +1406,9 @@ and is between 256 and 4096 characters. autoconfiguration. Ranges are in pairs (memory base and size). + printk.time= Show timing data prefixed to each printk message line + Format: <bool> (1/Y/y=enable, 0/N/n=disable) + profile= [KNL] Enable kernel profiling via /proc/profile Format: [schedule,]<number> Param: "schedule" - profile schedule points. @@ -1805,8 +1808,6 @@ and is between 256 and 4096 characters. thash_entries= [KNL,NET] Set number of hash buckets for TCP connection - time Show timing data prefixed to each printk message line - clocksource= [GENERIC_TIME] Override the default clocksource Override the default clocksource and use the clocksource with the name specified. --- linux-2622-rc2g5.orig/kernel/printk.c +++ linux-2622-rc2g5/kernel/printk.c @@ -449,17 +449,7 @@ static int printk_time = 1; #else static int printk_time = 0; #endif -module_param(printk_time, int, S_IRUGO | S_IWUSR); - -static int __init printk_time_setup(char *str) -{ - if (*str) - return 0; - printk_time = 1; - return 1; -} - -__setup("time", printk_time_setup); +module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR); __attribute__((weak)) unsigned long long printk_clock(void) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |