lkml.org 
[lkml]   [2007]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [kvm-devel] [PATCH 4/7] SMP: Implement on_one_cpu()
    On Thu, May 24, 2007 at 03:10:12PM +0300, Avi Kivity wrote:
    > This defines on_one_cpu() which is similar to smp_call_function_single()
    > except that it works if cpu happens to be the current cpu. Can also be
    > seen as a complement to on_each_cpu() (which also doesn't treat the
    > current cpu specially).
    >
    > Signed-off-by: Avi Kivity <avi@qumranet.com>
    > ---
    > include/linux/smp.h | 15 +++++++++++++++
    > kernel/softirq.c | 24 ++++++++++++++++++++++++
    > 2 files changed, 39 insertions(+), 0 deletions(-)
    >
    > +/*
    > + * Call a function on one processor
    > + */
    > +int on_one_cpu(int cpu, void (*func)(void *info), void *info,
    > + int retry, int wait);
    >

    Would you mind renaming that one to simply 'on_cpu'? It's even shorter and
    clearly everybody will know what its purpose is. Also I doubt we will ever
    have something like 'on_two_cpus'.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-24 15:39    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean