lkml.org 
[lkml]   [2007]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: 2.6.22-rc1-mm1 - s390 vs. md
    From
    Date
    On Wed, 2007-05-23 at 10:46 +0200, Cornelia Huck wrote:
    > Taking a quick look at the async_*.c stuff, the functions in question
    > basically seem to be of the form
    >
    > check_if_we_can_do_it_async();
    > if (async_ok) {
    > /* do async stuff */
    > /* that's where the dma mapping creeps in */
    > } else {
    > /* do it sync */
    > /* seems fine for us */
    > }

    Hmm, on what does the async_ok depend? Is that a runtime check that is
    done once or is it something more complicated like the availability of a
    dma slot? If it is a simple runtime check then there should be a
    operations structure that has indirect function pointers for the
    different async_memset_{sync,async}() functions. Instead of doing the
    async_ok check just call the function. That would save an if as well.

    --
    blue skies,
    Martin.

    "Reality continues to ruin my life." - Calvin.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-23 10:57    [W:0.021 / U:119.424 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site