lkml.org 
[lkml]   [2007]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] UDF: possible usage of uninitialized variables
    [Jan Kara - Tue, May 22, 2007 at 10:29:38PM +0200]
    | > A few variables could be used without being explicitly initialized.
    | > Fixed.
    | >
    | > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
    | > ---
    | >
    | >
    | > balloc.c | 6 +++++-
    | > super.c | 5 ++++-
    | > 2 files changed, 9 insertions(+), 2 deletions(-)
    | >
    | >
    | > diff --git a/balloc.c b/balloc.c
    | > index 4cec910..be37393 100644
    | > --- a/balloc.c
    | > +++ b/balloc.c
    | > @@ -744,7 +744,11 @@ static int udf_table_new_block(struct super_block * sb,
    | > uint32_t spread = 0xFFFFFFFF, nspread = 0xFFFFFFFF;
    | > uint32_t newblock = 0, adsize;
    | > uint32_t elen, goal_elen = 0;
    | > - kernel_lb_addr eloc, goal_eloc;
    | > + kernel_lb_addr eloc;
    | > + kernel_lb_addr goal_eloc = {
    | > + .logicalBlockNum = 0,
    | > + .partitionReferenceNum = 0,
    | > + };
    | > struct extent_position epos, goal_epos;
    | > int8_t etype;
    | As I read the code, I don't think it can happen goal_eloc is used
    | unitialized. Also please diff the tree completely, not just the udf
    | directory..
    |
    | > diff --git a/super.c b/super.c
    | > index 9b8644a..068a99c 100644
    | > --- a/super.c
    | > +++ b/super.c
    | > @@ -1358,7 +1358,10 @@ udf_load_partition(struct super_block *sb, kernel_lb_addr *fileset)
    | > case UDF_VIRTUAL_MAP15:
    | > case UDF_VIRTUAL_MAP20:
    | > {
    | > - kernel_lb_addr ino;
    | > + kernel_lb_addr ino = {
    | > + .logicalBlockNum = 0,
    | > + .partitionReferenceNum = 0,
    | > + };
    | >
    | > if (!UDF_SB_LASTBLOCK(sb))
    | > {
    | This one seems correct. Thanks for fixing this.
    |
    | Honza
    | --
    | Jan Kara <jack@suse.cz>
    | SuSE CR Labs
    |

    Sorry, that's my fault :(

    Cyrill

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-23 17:21    [W:0.037 / U:92.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site