![]() | |||||||||||||
Messages in this thread |
On 5/23/07, Michael-Luke Jones <mlj28@cam.ac.uk> wrote: >> Fair enough. However, this rather important issue is pretty much > undocumented (source code comments don't count) If header file for public interface (<linux/lzo1x.h> documents about 'unsafe' vs. 'safe' then it should be enough. > and Reiser4 is> already using the lzo1x_decompress() function rather than the > seemingly more appropriate lzo1x_decompress_safe() function... >> http://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-> rc2/2.6.22-rc2-mm1/broken-out/reiser4-use-lzo-library-functions.patch >> Perhaps a rename is in order:> lzo1x_decompress() => lzo1x_decompress_unsafe() > lzo1x_decompress_safe => lzo1x_decompress() > Or perhaps make reiserfs use _safe() instead - I think Richard has already submitted patch for same. - Nitin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-05-23 14:07 [from the cache] ©2003-2008 | |||||||||||||