Messages in this thread Patch in this message | | | Subject | patch usb-hub.c-loops-forever-on-resume-from-ram-due-to-bluetooth.patch added to gregkh-2.6 tree | From | <> | Date | Tue, 22 May 2007 16:53:14 -0700 |
| |
This is a note to let you know that I've just added the patch titled
Subject: USB: hub.c loops forever on resume from ram due to bluetooth
to my gregkh-2.6 tree. Its filename is
usb-hub.c-loops-forever-on-resume-from-ram-due-to-bluetooth.patch
This tree can be found at http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
From lkml@rtr.ca Mon May 14 16:48:14 2007 From: Mark Lord <lkml@rtr.ca> Date: Mon, 14 May 2007 19:48:02 -0400 Subject: USB: hub.c loops forever on resume from ram due to bluetooth To: Greg KH <gregkh@suse.de> Cc: Linux Kernel <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>, marcel@holtmann.org Message-ID: <4648F532.4030809@rtr.ca>
Okay, found it. The root cause here was a missing CONFIG_USB_SUSPEND=y, which means the hci_usb device never got marked as USB_STATE_SUSPENDED, which then caused the loop to go on forever.
The system works fine now with CONFIG_USB_SUSPEND=y in the .config.
Here's the patch to prevent future lockups for this or other causes. I no longer need it, but it does still seem a good idea.
Signed-off-by: Mark Lord <mlord@pobox.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/usb/core/hub.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -403,9 +403,10 @@ static void hub_tt_kevent (struct work_s struct usb_hub *hub = container_of(work, struct usb_hub, tt.kevent); unsigned long flags; + int limit = 100; spin_lock_irqsave (&hub->tt.lock, flags); - while (!list_empty (&hub->tt.clear_list)) { + while (--limit && !list_empty (&hub->tt.clear_list)) { struct list_head *temp; struct usb_tt_clear *clear; struct usb_device *hdev = hub->hdev;
Patches currently in gregkh-2.6 which might be from lkml@rtr.ca are
usb/usb-hub.c-loops-forever-on-resume-from-ram-due-to-bluetooth.patch - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |