Messages in this thread |  | | | Date | Tue, 22 May 2007 15:40:30 -0400 | | From | Dave Jones <> | | Subject | Re: [PATCH] add "notime" boot option |
| |
On Tue, May 22, 2007 at 12:09:38PM -0700, Randy Dunlap wrote: > --- linux-2622-rc2.orig/kernel/printk.c > +++ linux-2622-rc2/kernel/printk.c > @@ -458,9 +458,17 @@ static int __init printk_time_setup(char > printk_time = 1; > return 1; > } > - > __setup("time", printk_time_setup); > > +static int __init printk_notime_setup(char *str) > +{ > + if (*str) > + return 0; > + printk_time = 0; > + return 1; > +} > +__setup("notime", printk_notime_setup); > + > __attribute__((weak)) unsigned long long printk_clock(void) > { > return sched_clock();
Not disagreeing with the patch, but I wonder if it'd be a net win if we had a helper that would replace the zillion instances of "set this variable to a 0/1 depending if its prefixed with 'no'" with 1-2 lines.
Dave
-- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |