lkml.org 
[lkml]   [2007]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 47/69] IPV6: Send ICMPv6 error on scope violations.
    -stable review patch.  If anyone has any objections, please let us know.
    ---------------------

    From: David L Stevens <dlstevens@us.ibm.com>

    When an IPv6 router is forwarding a packet with a link-local scope source
    address off-link, RFC 4007 requires it to send an ICMPv6 destination
    unreachable with code 2 ("not neighbor"), but Linux doesn't. Fix below.

    Signed-off-by: David L Stevens <dlstevens@us.ibm.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>

    ---
    net/ipv6/ip6_output.c | 13 ++++++++++---
    1 file changed, 10 insertions(+), 3 deletions(-)

    --- linux-2.6.21.1.orig/net/ipv6/ip6_output.c
    +++ linux-2.6.21.1/net/ipv6/ip6_output.c
    @@ -449,10 +449,17 @@ int ip6_forward(struct sk_buff *skb)
    */
    if (xrlim_allow(dst, 1*HZ))
    ndisc_send_redirect(skb, n, target);
    - } else if (ipv6_addr_type(&hdr->saddr)&(IPV6_ADDR_MULTICAST|IPV6_ADDR_LOOPBACK
    - |IPV6_ADDR_LINKLOCAL)) {
    + } else {
    + int addrtype = ipv6_addr_type(&hdr->saddr);
    +
    /* This check is security critical. */
    - goto error;
    + if (addrtype & (IPV6_ADDR_MULTICAST|IPV6_ADDR_LOOPBACK))
    + goto error;
    + if (addrtype & IPV6_ADDR_LINKLOCAL) {
    + icmpv6_send(skb, ICMPV6_DEST_UNREACH,
    + ICMPV6_NOT_NEIGHBOUR, 0, skb->dev);
    + goto error;
    + }
    }

    if (skb->len > dst_mtu(dst)) {
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-21 21:49    [W:4.027 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site