lkml.org 
[lkml]   [2007]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/32] Blackfin arch: Fix bug using usb keyboard crashes kernel
On 5/21/07, Hennerich, Michael <Michael.Hennerich@analog.com> wrote:
> With CONFIG_VT (drivers/char/vt.c) enabled and a USB HID keyboard connected,
> we were seeing bad pointer dereferences in drivers/char/keyboard.c
>
> In function kbd_keycode vc_cons[fg_console].d was un-initialized.

On 5/21/07, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> Makes sense. Please consider adding this to the changelog. Thanks.

I am not an expert on this, but I don't see how vc_cons[fg_console].d
would be uninitialized. It is always set in
drivers/char/vt.c:con_init() and drivers/char/vt.c:vc_allocate(). The
conswitchp change affects vc->vc_sw but I don't see that being used in
drivers/char/keyboard.c:kbd_keycode() except indirectly via
set_console et al.

Perhaps I am missing something here?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-21 14:53    [W:0.032 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site