Messages in this thread | | | Date | Mon, 21 May 2007 15:50:32 +0300 | From | "Pekka Enberg" <> | Subject | Re: [PATCH 12/32] Blackfin arch: Fix bug using usb keyboard crashes kernel |
| |
On 5/21/07, Hennerich, Michael <Michael.Hennerich@analog.com> wrote: > With CONFIG_VT (drivers/char/vt.c) enabled and a USB HID keyboard connected, > we were seeing bad pointer dereferences in drivers/char/keyboard.c > > In function kbd_keycode vc_cons[fg_console].d was un-initialized.
On 5/21/07, Pekka Enberg <penberg@cs.helsinki.fi> wrote: > Makes sense. Please consider adding this to the changelog. Thanks.
I am not an expert on this, but I don't see how vc_cons[fg_console].d would be uninitialized. It is always set in drivers/char/vt.c:con_init() and drivers/char/vt.c:vc_allocate(). The conswitchp change affects vc->vc_sw but I don't see that being used in drivers/char/keyboard.c:kbd_keycode() except indirectly via set_console et al.
Perhaps I am missing something here? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |