Messages in this thread | | | Date | Wed, 2 May 2007 03:02:41 -0400 (EDT) | From | "Robert P. J. Day" <> | Subject | Re: [patch 01/10] compiler: define __attribute_unused__ |
| |
On Wed, 2 May 2007, Alexey Dobriyan wrote:
> On Tue, May 01, 2007 at 09:28:18PM -0700, David Rientjes wrote: > > +#define __attribute_unused__ __attribute__((unused)) > > Suggest __unused which is shorter and looks compiler-neutral.
not only that, but there are numerous files that *already* use "__unused":
$ grep -rw __unused * ... snip lots of output here ...
as well as a few files that can now have their definition of that removed:
$ grep -r "define __unused" * drivers/net/defxx.c:#define __unused __attribute__ ((unused)) drivers/net/declance.c:#define __unused __attribute__ ((unused)) drivers/misc/thinkpad_acpi.c:#define __unused __attribute__ ((unused))
i think "__unused" is the clear choice here.
rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |