Messages in this thread | | | Date | Wed, 2 May 2007 20:30:26 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 3/6] firewire: char device interface |
| |
On Wed, May 02, 2007 at 02:17:26PM +0200, Stefan Richter wrote: > +#include <asm/ioctl.h> > +#include <asm/types.h>
Always use the <linux/ versions.
> +struct fw_cdev_get_info { > + /* The version field is just a running serial number. We > + * never break backwards compatibility. Userspace passes in > + * the version it expects and the kernel passes back the > + * highest version it can provide. Even if the structs in > + * this interface are extended in a later version, the kernel > + * will not copy back more data than what was present in the > + * interface version userspace expects. */ > + __u32 version;
Please don't even try to build interfaces this complicated. If your current interface needs changes at some point just introduce new ioctls.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |