Messages in this thread | | | Date | Fri, 18 May 2007 00:16:04 -0700 (PDT) | Subject | Re: [PATCH 05/14] all-archs: consolidate .data section definition in asm-generic | From | David Miller <> |
| |
From: Sam Ravnborg <sam@ravnborg.org> Date: Fri, 18 May 2007 08:52:57 +0200
> >From 653bc43c6c2c292e6abc98860fd241eb12e2c80f Mon Sep 17 00:00:00 2001 > From: Sam Ravnborg <sam@ravnborg.org> > Date: Thu, 17 May 2007 13:38:44 +0200 > Subject: [PATCH 05/14] all-archs: consolidate .data section definition in asm-generic > > With this consolidation we can now modify the .data > section definition in one spot for all archs. > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Thanks for doing these kinds of consolidations Sam, most of us arch maintainers really appreciate it.
Looking at these patches reminds me of a quirk in the generic RODATA definition:
> #define RODATA \ > . = ALIGN(4096); \ > .rodata : AT(ADDR(.rodata) - LOAD_OFFSET) { \
It uses ALIGN(4096) which is likely supposed to be something like ALIGN(PAGE_SIZE). Perhaps we should handle this by definiting a LD_PAGE_SIZE at the top of vmlinux.ld.S files that need a value other than 4096, and define the default of 4096 in asm-generic/vmlinux.lds.h?
If you could take care of this I'd really appreciate it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |