[lkml]   [2007]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free
    John W. Linville wrote:
    > First, please send all wireless patches to
    >, and be sure to CC me as well...thanks!
    > On Sat, May 19, 2007 at 12:50:31AM +0800, Eugene Teo wrote:
    >> libertas_upload_rx_packet() calls netif_rx() before returning, and it always return 0.
    >> Also within libertas_upload_rx_packet(), it will initialize skb->protocol anyways.
    >> Spotted by the Coverity checker.
    > A nearly identical patch was posted by Florin Malita <>
    > to netdev (also the wrong list) on Wednesday evening.

    Nod. I wasn't subscribed to netdev list.

    >> done:
    >> LEAVE();
    >> - skb->protocol = __constant_htons(0x0019); /* ETH_P_80211_RAW */
    >> -
    > Except for this this intentional?

    skb could have been freed by then. And, in libertas_upload_rx_packet(), skb->protocol
    is initialized by eth_type_trans(skb, priv->wlan_dev.netdev).


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-05-19 05:19    [W:0.020 / U:5.848 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site