lkml.org 
[lkml]   [2007]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: aio is unlikely
    Date
    In article <058f01c7998e$1406e370$650df7cd@MUMBA> you wrote:
    >> -#define in_aio() !is_sync_wait(current->io_wait)
    >> +#define in_aio() (unlikely(!is_sync_wait(current->io_wait)))
    >
    > Shouldn't unlikely() go where in_aio() is actually used, if we printk(error)
    > there?

    Actually I would just remove that define and use the method directly, if
    this is the only place where it is used. If it is used in multiple places,
    the unlikely is most likely wrong .)

    Gruss
    Bernd
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-18 23:33    [W:0.018 / U:1.004 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site