lkml.org 
[lkml]   [2007]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH (v2)] crypto: Remove pointless padlock module
On Sun, Apr 29, 2007 at 09:01:10AM +0100, Simon Arlott wrote:
> When this is compiled in it is run too early to do anything useful:
> [ 6.052000] padlock: No VIA PadLock drivers have been loaded.
> [ 6.052000] padlock: Using VIA PadLock ACE for AES algorithm.
> [ 6.052000] padlock: Using VIA PadLock ACE for SHA1/SHA256 algorithms.
>
> When it's a module it isn't doing anything special, the same functionality
> can be provided in userspace by "probeall padlock padlock-aes padlock-sha"
> in modules.conf if it is required.

BTW, I noticed that this prevented CRYPTO_ALGAPI from being marked as m
since it was selected by CRYPTO_DEV_PADLOCK. So I'm turning it into a
tristate again.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
d158325e407864793c5b0fbc85c74702753333b9
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index e678a33..bb90cbd 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -1,10 +1,10 @@
menu "Hardware crypto devices"

config CRYPTO_DEV_PADLOCK
- bool "Support for VIA PadLock ACE"
+ tristate "Support for VIA PadLock ACE"
depends on X86_32
select CRYPTO_ALGAPI
- default y
+ default m
help
Some VIA processors come with an integrated crypto engine
(so called VIA PadLock ACE, Advanced Cryptography Engine)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2007-05-18 08:49    [W:0.066 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site