lkml.org 
[lkml]   [2007]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] drm modesetting core
    Il Thu, May 17, 2007 at 06:04:54PM -0700, Jesse Barnes ha scritto: 
    > On Thursday, May 17, 2007, Luca Tettamanti wrote:
    > > Il Thu, May 17, 2007 at 03:37:45PM -0700, Jesse Barnes ha scritto:
    > > > This patch adds the core of the new DRM based modesetting system.
    > >
    > > A couple of comments on drm_fb since I'm somewhat familiar with fb code:
    > > > new file mode 100644
    > > > index 0000000..0d06792
    > > > --- /dev/null
    > > > +++ b/linux-core/drm_edid.c
    > > > @@ -0,0 +1,467 @@
    > > > +/*
    > > > + * Copyright (c) 2007 Intel Corporation
    > > > + * Jesse Barnes <jesse.barnes@intel.com>
    > > > + *
    > > > + * DDC probing routines (drm_ddc_read & drm_do_probe_ddc_edid)
    > > > originally from
    > > > + * FB layer.
    > >
    > > Hum, why are you duplicating them here? fbmon.c has the
    > > infrastructure for parsing and even fixing known-broken EDIDs.
    >
    > Yeah, there's more sharing that could be done... though I don't think the
    > fb layer has the bits to actually grab EDIDs.

    There are the I2C functions (fb_do_probe_ddc_edid, fb_ddc_read - I wrote
    them for the radeon driver, but now are available for general use) which
    will issue the read command; fbmon.c has the stuff for parsing the EDID;
    you usualy build a DB of supported modes which is then used to validate
    the mode requested by the user. Of course each driver has to implement
    the I2C adapter.

    > Also, DRM is shared with BSD...

    Your patch already uses 'struct i2c_adapter' in drm_edid.c, is it
    portable?

    Luca
    --
    "Vorrei morire ucciso dagli agi. Vorrei che di me si dicesse: ``Com'è
    morto?'' ``Gli è scoppiato il portafogli''" -- Marcello Marchesi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-18 21:35    [W:0.022 / U:92.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site