Messages in this thread | | | Date | Fri, 18 May 2007 13:46:23 -0400 | From | "John W. Linville" <> | Subject | Re: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free |
| |
First, please send all wireless patches to linux-wireless@vger.kernel.org, and be sure to CC me as well...thanks!
On Sat, May 19, 2007 at 12:50:31AM +0800, Eugene Teo wrote: > libertas_upload_rx_packet() calls netif_rx() before returning, and it always return 0. > Also within libertas_upload_rx_packet(), it will initialize skb->protocol anyways. > > Spotted by the Coverity checker.
A nearly identical patch was posted by Florin Malita <fmalita@gmail.com> to netdev (also the wrong list) on Wednesday evening.
> done: > LEAVE(); > > - skb->protocol = __constant_htons(0x0019); /* ETH_P_80211_RAW */ > -
Except for this part...is this intentional?
John -- John W. Linville linville@tuxdriver.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |