Messages in this thread Patch in this message | | | Date | Thu, 17 May 2007 18:15:59 -0400 | From | Ed Sweetman <> | Subject | Re: [PATCH] powernow-k8: depend on acpi-processor for SMP systems |
| |
Dave Jones wrote: > On Thu, May 17, 2007 at 05:40:31PM -0400, Ed Sweetman wrote: > > > Here's a patch > > (please inline patches so they can be quoted in replies). > > having this as a tristate makes no sense, that code can't be modular. > Also, there's a gratuitous whitespace change, and the default should > probably stay. > > If there's consensus we should make this a user-visible option, > we can do that, though I still don't think this is any more > perfect than the other option that Daniel posted. > > Dave > > yes i know, i rushed it before dinner. maybe this one?
--- ./linux-backup/arch/x86_64/kernel/cpufreq/Kconfig 2007-02-04 13:44:54.000000000 -0500 +++ ./linux-2.6.21-rc5-mm2/arch/x86_64/kernel/cpufreq/Kconfig 2007-05-17 18:13:07.000000000 -0400 @@ -10,20 +10,27 @@ comment "CPUFreq processor drivers" -config X86_POWERNOW_K8 +config X86_POWERNOW_K8 tristate "AMD Opteron/Athlon64 PowerNow!" select CPU_FREQ_TABLE help This adds the CPUFreq driver for mobile AMD Opteron/Athlon64 processors. + An acpi interface is available if acpi support has been selected. + This is required for multi-socket and other systems but not necessarily required for UP single socket systems. For details, take a look at <file:Documentation/cpu-freq/>. If in doubt, say N. config X86_POWERNOW_K8_ACPI - bool - depends on X86_POWERNOW_K8 && ACPI_PROCESSOR - depends on !(X86_POWERNOW_K8 = y && ACPI_PROCESSOR = m) + bool "ACPI Support" + select ACPI_PROCESSOR + depends on X86_POWERNOW_K8 + help + This provides access to the acpi tables for full p-state functionality. This driver is also required + for cpufreq to work with multi-socket and other smp systems. + + It is safe to say Y here. default y config X86_SPEEDSTEP_CENTRINO
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |