lkml.org 
[lkml]   [2007]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] bluetooth: fix locking in hci_sock_dev_event()
    From
    From: Satyam Sharma <ssatyam@cse.iitk.ac.in>
    Date: Thu, 17 May 2007 11:13:36 +0530 (IST)

    > [PATCH] bluetooth: fix locking in hci_sock_dev_event()
    >
    > We presently use lock_sock() to acquire a lock on a socket in
    > hci_sock_dev_event(), but this goes BUG because lock_sock()
    > can sleep and we're already holding a read-write spinlock at
    > that point. So, we must use the non-sleeping BH version,
    > bh_lock_sock().
    >
    > However, hci_sock_dev_event() is called from user context and
    > hence using simply bh_lock_sock() will deadlock against a
    > concurrent softirq that tries to acquire a lock on the same
    > socket. Hence, disabling BH's before acquiring the socket lock
    > and enable them afterwards, is the proper solution to fix
    > socket locking in hci_sock_dev_event().
    >
    > Cc: David Miller <davem@davemloft.net>
    > Signed-off-by: Satyam Sharma <ssatyam@cse.iitk.ac.in>
    > Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    > Signed-off-by: Jiri Kosina <jkosina@suse.cz>

    Thanks I'll merge this in.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-17 07:55    [W:0.021 / U:2.328 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site