lkml.org 
[lkml]   [2007]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] uselib: add missing MNT_NOEXEC check
On 5/17/07, Christoph Hellwig <hch@lst.de> wrote:
> We don't allow loading ELF shared library from noexec points so the
> same should apply to sys_uselib aswell.

Correct. But...

> error = -EINVAL;
> + if (nd.mnt->mnt_flags & MNT_NOEXEC)
> + goto exit;

... the error here should be EACCES. Aside from that you get an ACK from me.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-17 18:17    [W:0.039 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site