Messages in this thread | | | Subject | Re: [PATCH] Remove duplicate ID in ipaq driver | From | Ben Collins <> | Date | Wed, 16 May 2007 17:36:48 -0400 |
| |
On Wed, 2007-05-16 at 13:59 -0700, Roland Dreier wrote: > > /* The first entry is a placeholder for the insmod-specified device */ > > - { USB_DEVICE(0x049F, 0x0003) }, > > Is it obvious why this patch is correct? Especially given the > comment just before the line you delete, and the code > > if (vendor) { > ipaq_id_table[0].idVendor = vendor; > ipaq_id_table[0].idProduct = product; > } > > in ipaq_init()?
My mistake, quick on the patching going through this dupe list.
Might I add that this is terrible use of the device table, though. Clutters userspace, and adds processing to module-init-tools programs.
-- Ubuntu : http://www.ubuntu.com/ Linux1394: http://wiki.linux1394.org/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |