lkml.org 
[lkml]   [2007]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Remove duplicate ID in ipaq driver
From
Date
On Wed, 2007-05-16 at 13:59 -0700, Roland Dreier wrote:
> > /* The first entry is a placeholder for the insmod-specified device */
> > - { USB_DEVICE(0x049F, 0x0003) },
>
> Is it obvious why this patch is correct? Especially given the
> comment just before the line you delete, and the code
>
> if (vendor) {
> ipaq_id_table[0].idVendor = vendor;
> ipaq_id_table[0].idProduct = product;
> }
>
> in ipaq_init()?

My mistake, quick on the patching going through this dupe list.

Might I add that this is terrible use of the device table, though.
Clutters userspace, and adds processing to module-init-tools programs.

--
Ubuntu : http://www.ubuntu.com/
Linux1394: http://wiki.linux1394.org/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-16 23:39    [W:0.044 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site