Messages in this thread | | | Date | Tue, 15 May 2007 13:12:42 +0900 | From | Tsutomu OWA <> | Subject | Re: [patch 4/4] powerpc 2.6.21-rt1: reduce scheduling latency by changing tlb flush size |
| |
At Mon, 14 May 2007 16:40:02 +0200, Arnd Bergmann wrote: > > On Monday 14 May 2007, Tsutomu OWA wrote: > > --- linux-2.6.21-rt1/include/asm-powerpc/tlbflush.h 2007-04-26 12:08:32.000000000 +0900 > > +++ rt/include/asm-powerpc/tlbflush.h 2007-05-14 16:12:47.000000000 +0900 > > @@ -25,7 +25,12 @@ struct mm_struct; > > #include <linux/percpu.h> > > #include <asm/page.h> > > > > +#if defined(CONFIG_PPC_CELLEB) && defined(CONFIG_PREEMPT_RT) > > +/* Since tlb flush takes long time on Celleb, reduce it to 1 when Celleb && RT */ > > +#define PPC64_TLB_BATCH_NR 1
> With this code, you get silent side-effects of enabling PPC_CELLEB > along with another platform.
Yeah, thank you for pointing it out. I'll send revised patch later.
> Maybe instead you should change the hpte_need_flush() to always flush > when running on the celleb platform and PREEMPT_RT is enabled.
Hmm... Is it in linux-2.6.21? grep'ing it did not help...
Is http://patchwork.ozlabs.org/linuxppc/patch?id=10361 is the first place where the hpte_need_flush() appears?
-- owa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |