lkml.org 
[lkml]   [2007]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] LogFS take three
    On Tue, 15 May 2007 20:37:25 +0200, Sam Ravnborg wrote:
    > On Tue, May 15, 2007 at 05:19:20PM +0200, Jörn Engel wrote:
    > > [ I have put everyone that gave comments to the last patch on Cc:. Hope
    > > that doesn't offend anyone. ]
    > >
    > >
    > > Add LogFS, a scalable flash filesystem.
    >
    > Have you run sparse on this code?

    Several thousand times. :)

    > I do not recall if you have written something about it.
    > I do not see any obvious things sparse would catch (just browsing quickly)
    > but it's always a good thing to do.

    Absolutely! I added this line for sparse:
    +#define __CHECK_ENDIAN__

    Not sure how much of the kernel is endian-clean. Logfs should be.

    > +++ linux-2.6.21logfs/fs/logfs/progs/fsck.c 2007-05-15 00:54:22.000000000 +0200
    > @@ -0,0 +1,332 @@
    > +/*
    > + * fs/logfs/prog/fsck.c - filesystem check
    > + *
    > + * As should be obvious for Linux kernel code, license is GPLv2
    > + *
    > + * Copyright (c) 2005-2007 Joern Engel
    > + *
    > + * In principle this could get moved to userspace. However it might still
    > + * make some sense to keep it in the kernel. It is a pure checker and will
    > + * only report problems, not attempt to repair them.
    > + */
    > +#include "../logfs.h"
    > +
    > If potential userspace tools needs to include ../logfs.h then there is
    > something that ought to be moved to include/linux/logfs.h instead.

    There shouldn't be anything left in ../logfs.h that is needed for
    userspace. But the kernel fsck is lame and calls into functions like
    iget(), which it pulls in from ../logfs.h.

    Jörn

    --
    The only real mistake is the one from which we learn nothing.
    -- John Powell
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-15 21:17    [W:0.021 / U:60.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site