Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] pasemi: Electra CF driver | Date | Tue, 15 May 2007 11:52:23 +0200 |
| |
On Tuesday 15 May 2007, Olof Johansson wrote: > Driver for the CompactFlash slot on the PA Semi Electra eval board. It's > a simple device sitting on localbus, with interrupts and detect/voltage > control over GPIO.
The driver looks really good, there is nothing for me to complain about.
> The driver is implemented as an of_platform driver, and adds localbus > as a bus being probed by the of_platform framework.
I supposed "localbus" is what the current firmware ships with in the device tree, right? If you still have the choice on how this is represented it might be better not to invent another device-type but rather make this "soc" or whatever existing type we know about.
Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |