lkml.org 
[lkml]   [2007]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support
On Wed, 09 May 2007 02:31:25 +0400
Vitaly Bordug <vitb@kernel.crashing.org> wrote:

> +/*
> + * Some internal interrupt registers use an 8-bit mask for the interrupt
> + * level instead of a number.
> + */
> +static inline uint mk_int_int_mask(uint mask) {
> + return (1 << (7 - (mask/2)));
> +}

grumble. "uint" isn't a favoured "type". Please prefer to
use "unsigned int" if that's what is meant. Or maybe u32,
if that's more appropriate - and it probably is, as we're
dealing with device registers here.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-14 23:25    [W:0.211 / U:0.568 seconds]
©2003-2014 Jasper Spaans. Advertise on this site