lkml.org 
[lkml]   [2007]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Make appletouch shut up when it has nothing to say
    From
    Date
    On Sun, 2007-05-13 at 20:57 +0100, Matthew Garrett wrote:
    > Ok, I've tidied this up a little. I've separated the actual mode init
    > code into a separate function in order to avoid code duplication, and no
    > longer creating a new workqueue. The only other change is something that
    > I /think/ is actually a bug in the driver to begin with, but I'd like
    > some more feedback on that first - the first packet sent after the mode
    > change has 0x20 in the final byte. This seems to be interpreted as a
    > left mouse button press. As a result, moving the touchpad sends a false
    > press after every reinitialisation, or (approximately) every time the
    > pointer is moved. As far as I can tell this also happens with the
    > existing code, but is probably not noticable there because it won't
    > appear again after the first touch on the pad. Just skipping that case
    > seems to work fine.

    This patch indeed fixes the problem and I have yet to observe problems
    with it... However I don't know whether a re-init is the intended way of
    dealing with it...

    Soeren
    --
    Sometimes, there's a moment as you're waking, when you become aware of
    the real world around you, but you're still dreaming.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-14 02:23    [W:0.020 / U:0.748 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site