lkml.org 
[lkml]   [2007]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] Fix UCB1x00 driver to use sched_setscheduler
    At Sat, 12 May 2007 15:10:27 +0200,
    Thomas Gleixner wrote:
    >
    > On Fri, 2007-05-11 at 19:39 +0900, Satoru Takeuchi wrote:
    > > Fix Touchscreen driver for UCB1x00-based touchscreens to use
    > > sched_setscheduler() instead of setting the fields of task_struct directly.
    > >
    > > Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
    > >
    > > Index: linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c
    > > ===================================================================
    > > --- linux-2.6.21-fix-ucb-drivers.orig/drivers/mfd/ucb1x00-ts.c 2007-05-11 18:53:36.000000000 +0900
    > > +++ linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c 2007-05-11 19:33:20.000000000 +0900
    > > @@ -214,8 +214,9 @@ static int ucb1x00_thread(void *_ts)
    > > * We could run as a real-time thread. However, thus far
    > > * this doesn't seem to be necessary.
    > > */
    > > -// tsk->policy = SCHED_FIFO;
    > > -// tsk->rt_priority = 1;
    > > +// struct sched_param param = { .sched_priority = 1 };
    > > +//
    > > +// sched_setscheduler(tsk, SCHED_FIFO, &param);
    >
    > Can we please remove the unused code completely instead of replacing it
    > by more commented out code ?

    It's OK to me, but I'm not the driver writer and doesn't know how important
    are those comments. If removing them is better for driver writers too, here
    is the patch.

    Thanks,

    Satoru

    ---
    Remove unnecesary comments on driver for UCB1x00-based touchscreens.

    Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>

    Index: linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c
    ===================================================================
    --- linux-2.6.21-fix-ucb-drivers.orig/drivers/mfd/ucb1x00-ts.c 2007-05-11 18:53:36.000000000 +0900
    +++ linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c 2007-05-14 08:44:03.000000000 +0900
    @@ -199,7 +199,7 @@ static inline int ucb1x00_ts_pen_down(st
    }

    /*
    - * This is a RT kernel thread that handles the ADC accesses
    + * This is a kernel thread that handles the ADC accesses
    * (mainly so we can use semaphores in the UCB1200 core code
    * to serialise accesses to the ADC).
    */
    @@ -210,13 +210,6 @@ static int ucb1x00_thread(void *_ts)
    DECLARE_WAITQUEUE(wait, tsk);
    int valid;

    - /*
    - * We could run as a real-time thread. However, thus far
    - * this doesn't seem to be necessary.
    - */
    -// tsk->policy = SCHED_FIFO;
    -// tsk->rt_priority = 1;
    -
    valid = 0;

    add_wait_queue(&ts->irq_wait, &wait);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-05-14 02:01    [W:0.025 / U:0.768 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site