lkml.org 
[lkml]   [2007]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/2] leds:arch/sh/boards/landisk LEDs supports
    From
    Date
    On Wed, 2007-05-09 at 20:03 +0400, Anton Vorontsov wrote:
    > Following patch sitting for a long time in our handhelds.org tree.
    >
    > kogiidena, I'm almost sure you'll find it useful, just apply patch,
    > and implement .is_led_supported function for your trigger, which will
    > eliminate trigger showing in
    > /sys/class/leds/LED_WHICH_NOT_SUPPORTS_CUSTOM_TRIGGER/triggers

    I like the approach and will apply something like this. Comments
    follow...

    > Custom triggers support, which are might not supported by all LEDs
    >
    > Signed-off-by: Anton Vorontsov <cbou@mail.ru>
    >
    > diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
    > index 454fb09..0af0d61 100644
    > --- a/drivers/leds/led-triggers.c
    > +++ b/drivers/leds/led-triggers.c
    > @@ -53,6 +53,9 @@ ssize_t led_trigger_store(struct class_device *dev, const char *buf,
    > read_lock(&triggers_list_lock);
    > list_for_each_entry(trig, &trigger_list, next_trig) {
    > if (!strcmp(trigger_name, trig->name)) {
    > + if (trig->is_led_supported &&
    > + !trig->is_led_supported(led_cdev)) break;

    Missing newline.

    > @@ -85,6 +88,8 @@ ssize_t led_trigger_show(struct class_device *dev, char *buf)
    > if (led_cdev->trigger && !strcmp(led_cdev->trigger->name,
    > trig->name))
    > len += sprintf(buf+len, "[%s] ", trig->name);
    > + else if (trig->is_led_supported &&
    > + !trig->is_led_supported(led_cdev)) continue;

    ditto.

    > @@ -127,6 +132,7 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trigger)
    > led_cdev->trigger->deactivate(led_cdev);
    > led_set_brightness(led_cdev, LED_OFF);
    > }
    > + led_cdev->trigger = trigger;
    > if (trigger) {
    > write_lock_irqsave(&trigger->leddev_list_lock, flags);
    > list_add_tail(&led_cdev->trig_list, &trigger->led_cdevs);
    > @@ -134,7 +140,6 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trigger)
    > if (trigger->activate)
    > trigger->activate(led_cdev);
    > }
    > - led_cdev->trigger = trigger;
    > }
    >
    > void led_trigger_set_default(struct led_classdev *led_cdev)

    Why was the above was changed?

    I think we've discussed this before and it would be better to add a
    trigger parameter to activate/deactivate if we really need it. Anyhow,
    its not part of this patch and if you want that it should be in a
    separate one with accompanying rational.

    Can you resend with the above fixed and I'll apply.

    Thanks,

    Richard


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-14 01:19    [W:0.032 / U:90.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site