lkml.org 
[lkml]   [2007]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] mm: swap prefetch improvements
    Date
    On Saturday 12 May 2007 15:51, Paul Jackson wrote:
    > Con wrote:
    > > Hmm I'm not really sure what it takes to make it cpuset aware;
    > > ...
    > > It is numa aware to some degree. It stores the node id and when it starts
    > > prefetching it only prefetches to nodes that are suitable for prefetching
    > > to ...
    > > It would be absolutely trivial to add a check for 'number_of_cpusets' <=
    > > 1 in the prefetch_enabled() function. Would you like that?
    >
    > Hmmm ... it seems that we shadow boxing here ... trying to pick a solution
    > to solve a problem when we aren't even sure we have a problem, much less
    > what the problem is.
    >
    > That does not usually lead to the right path.
    >
    > Could you put some more effort into characterizing what problems
    > can arise if one has prefetch and cpusets active at the same time?
    >
    > My first wild guess is that the only incompatibility would have been that
    > prefetch might mess up NUMA placement (get pages on wrong nodes), which
    > it seems you have tried to address in your current patches. So it would
    > not surprise me if there was no problem here.

    Ummm this is what I've been saying for over a year now but noone has been
    listening.

    > We may just have to lean on Nick some more, if he is the only one who
    > understands what the problem is, to try again to explain it to us.

    --
    -ck
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-12 09:25    [W:4.106 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site