lkml.org 
[lkml]   [2007]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] AFS: Fix interminable loop in afs_write_back_from_locked_page()
Date
Andrew Morton <akpm@linux-foundation.org> wrote:

> Yes, it's a shame that there doesn't seem to be a fine-grained way of
> turning on -W's useful bits.

You can turn off -W's undesirable bits. For net/rxrpc/ and fs/afs/ at least,
adding:

CFLAGS += -W -Wno-unused-parameter

to the Makefile generates no warnings. Perhaps this should be added to the
master Makefile.

Adding -Wsign-compare finds some stuff that I will fix. It also finds some
stuff in the main and the networking headers. This is a really useful option
and found some tricky bugs in CacheFiles. I would endorse adding this
generally too.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-11 12:07    [W:0.045 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site