Messages in this thread | | | Date | Thu, 10 May 2007 07:56:36 +0100 | From | Christoph Hellwig <> | Subject | Re: [patch 06/10] Linux Kernel Markers - Non optimized architectures |
| |
On Wed, May 09, 2007 at 09:56:01PM -0400, Mathieu Desnoyers wrote: > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > +++ linux-2.6-lttng/include/asm-arm/marker.h 2007-05-09 18:16:05.000000000 -0400 > @@ -0,0 +1,13 @@ > +/* > + * marker.h
I think I've told you a few times already that mentioning the filename in the file is pretty braindead and not exactly helpful.
Would be good to have an automatic check for this as I'm getting a little tired of mentioning this three times a day.
> + * > + * Code markup for dynamic and static tracing. Architecture specific > + * optimisations. > + * > + * No optimisation implemented. > + * > + * This file is released under the GPLv2. > + * See the file COPYING for more details. > + */ > + > +#include <asm-generic/marker.h>
I don't think any kind of copyright statement or comment is appopinquate for a file that does nothing but including an asm-generic header. This file should a single line, namely:
#include <asm-generic/marker.h>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |