[lkml]   [2007]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/12] crypto: don't pollute the global namespace with sg_next()
    Jens Axboe wrote:
    > It's a subsystem function, prefix it as such.

    Jens, Boaz and I talked about this over lunch.
    I wonder whether the crypto code must use your implementation
    instead of its own as it needs to over the sglist, e.g. for
    calculating iscsi (data) digest.

    The crypto implementation of chained sglists in crypto/scatterwalk.h
    determines the chain link by !sg->length which will sorta work
    with your implementation, however the marker bit on page pointer must
    be cleared to use it.

    Also, is it possible that after the original sglist has gone through
    dma_map_sg and entries were merged, some entries will have zero
    length? I'm not sure... If so, if the crypto implementation scans
    the sg list after it was dma mapped (maybe in a retry path) it
    may hit an entry that looks to it like a chaining link. This
    might be an existing bug and another reason for the crypto code
    to use your implementation.



    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-05-10 15:59    [W:0.019 / U:9.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site