Messages in this thread | | | Date | Thu, 10 May 2007 13:53:48 +0200 | From | Tejun Heo <> | Subject | Re: libata reset-seq merge broke sata_sil on sh |
| |
Some more thoughts.
Tejun Heo wrote: > Hello, > > Paul Mundt wrote: > [--snip, thanks a lot for the detailed report--] >> However, if I go back before any of the reset changes were introduced, >> things were working fine, and there were no problems with waiting for >> the reset. Ideas? > > Hmm... It worked so well on all my sil's. I'm a bit puzzled because we > also failed the same condition before the change too. The only change > is we're less patient with the initial tries but in the end we give more > than enough time to the device to prepare itself. > > * Does your drive start spun down when it boots? Can you post dmesg > with printk timestamp turned on with kernel prior to reset-seq merge? > > * In ata_bus_softreset() and sata_std_hardreset(), there's msleep(150) > delay before checking the status post-reset. Does increasing the delay > make any difference? Please try to increase it exponentially till it > reaches 10sec.
* According to the report, things still work till 27c78b37 - commit for the actual merge and there's no related change till the current master from there. So, which commit actually breaks detection? Or is detection just flaky after b8cffc6a?
* How does things work on 9b89391c?
Also, please turn on printk timestamp on all reports so that we can now the timeline of things.
Thanks.
-- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |