Messages in this thread | | | Date | Tue, 1 May 2007 19:16:32 -0700 | From | "Nate Diller" <> | Subject | Re: [PATCH] zero_user_page uses in fs/buffer.c and fs/libfs.c |
| |
On 5/1/07, Christoph Lameter <clameter@sgi.com> wrote: > On Tue, 1 May 2007, Andrew Morton wrote: > > > As Satyam said, this will sometimes cause us to map and unmap the page > > twice, and to run flush_dcache_page() twice. In not-terribly-uncommon > > circumstances in very frequently called functions. > > > > Doesn't seem worth it to me. > > Ok but we have that code three times. Should I add a variant of > zero_user_page that zeroes everything but the section specified? > > zero_user_page_allbut() ?
the function already exists, it's called simple_prepare_write(), and i thought there were patches to convert those callsites in -mm ... although it looks like i let a review comment on that slide by. I need to redo a bunch of patches for re-submission anyway, so i guess i'll deal with that tomorrow.
NATE - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |