Messages in this thread |  | | | Date | Tue, 01 May 2007 19:59:21 -0400 | | From | Mark Lord <> | | Subject | Re: [PATCH] Remove unnecessary irq disabling |
| |
Glauber de Oliveira Costa wrote: > RR asks us if it is really necessary to disable interrupts in > setup_secondary_APIC_clock(). The answer is no, since setup_APIC_timer() > starts by saving irq flags, which also disables them. > > Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com> > > --- a/arch/x86_64/kernel/apic.c > +++ b/arch/x86_64/kernel/apic.c > @@ -875,9 +875,7 @@ void __init setup_boot_APIC_clock (void) > > void __cpuinit setup_secondary_APIC_clock(void) > { > - local_irq_disable(); /* FIXME: Do we need this? --RR */ > setup_APIC_timer(calibration_result); > - local_irq_enable(); > } > > void disable_APIC_timer(void)
Okay, I'll bite: before the patch, this code would exit with interrupts *enabled*, always. Now it does not.
What does that break, or was it already broken and this fixes it?
Cheers - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |