![]() | |||||||||||||
Messages in this thread |
Andrew Morton wrote: > On Mon, 30 Apr 2007 08:44:14 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote: > >> On Mon, 30 Apr 2007 07:35:00 -0700 (PDT) David Rientjes wrote: >> >>> Only declare mega_proc_dir_entry() in CONFIG_PROC_FS. We should call >>> mega_create_proc_entry() only in this configuration so make sure it's defined >>> if we call it. >>> >>> Only define mega_adapinq() in CONFIG_PROC_FS. mega_internal_dev_inquiry() >>> and mega_print_inquiry() were never declared without CONFIG_PROC_FS so >>> make sure we don't have prototypes for them if we aren't going to define >>> them. >>> >>> Move the declaration of 'buf' in mega_remove_one() because we only use it >>> in the CONFIG_PROC_FS case. >> Just noting the presence of: >> http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc7/2.6.21-rc7-mm2/broken-out/megaraid-fix-warnings-when-config_proc_fs=n.patch >> > > That patch has been submitted fourteen times in the past year, and was > completely ignored each time. > >> Oh, and that SCSI patches need to go to the linux-scsi mailing list. >> > > There seem to be little point in doing that. Yes, I guess I was speaking theory instead of reality. I suppose that one alternative is for you to merge those long-queued patches instead of sending them on to linux-scsi over and over again. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-05-01 04:25 [from the cache] ©2003-2008 | |||||||||||||