lkml.org 
[lkml]   [2007]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [QUICKLIST 3/4] Quicklist support for x86_64
    On Mon, 9 Apr 2007, Andrew Morton wrote:

    > On Mon, 9 Apr 2007 11:25:20 -0700 (PDT)
    > Christoph Lameter <clameter@sgi.com> wrote:
    >
    > > -static inline pgd_t *pgd_alloc(struct mm_struct *mm)
    > > +static inline void pgd_ctor(void *x)
    > > +static inline void pgd_dtor(void *x)
    >
    > Seems dumb to inline these - they're only ever called indirectly, aren't
    > they?

    Yes.. In most cases they are not called at all because NULL is passed.
    Then the function call can be removed by the compiler from the in line
    functions.

    > This means (I think) that the compiler will need to generate an out-of-line
    > copy of these within each compilation unit which passes the address of these
    > functions into some other function.

    The function is constant. Constant propagation will lead to the function
    being included in the inline function.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-10 00:03    [W:0.020 / U:88.704 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site