Messages in this thread |  | | | Date | Sat, 07 Apr 2007 19:30:14 +1000 | | From | Nick Piggin <> | | Subject | Re: [PATCH, take4] FUTEX : new PRIVATE futexes |
| |
Eric Dumazet wrote: > Hi all > > Updates on this take4 : > > - All remarks from Nick were addressed I hope
Yeah looks very nice. Thanks for doing that.
> > - Current mm code have a problem with 64bit futexes, as spoted by Nick : > > get_futex_key() does a check against sizeof(u32) regardless of futex being 64bits or not. > So it is possible a 64bit futex spans two pages of memory... > I had to change get_futex_key() prototype to be able to do a correct test.
I wonder if it should be encfocing alignment to keep in on 1 page?
Otherwise, Acked-by: Nick Piggin <npiggin@suse.de>
I'll be away for a couple of days, but I'll look at running some performance tests when I get back.
Thanks, Nick
-- SUSE Labs, Novell Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |