Messages in this thread | | | Date | Sat, 7 Apr 2007 09:48:51 +0530 | From | Srivatsa Vaddagiri <> | Subject | Re: [PATCH 3/7] Containers (V8): Add generic multi-subsystem API to containers |
| |
On Fri, Apr 06, 2007 at 04:32:24PM -0700, menage@google.com wrote: > +static int attach_task(struct container *cont, struct task_struct *tsk) > {
[snip]
> + task_lock(tsk);
You need to check here if task state is PF_EXITING and fail with -ESRCH if so? Otherwise we risk breaking refcount on init_container_group.
> + rcu_assign_pointer(tsk->containers, newcg); > + task_unlock(tsk);
-- Regards, vatsa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |