lkml.org 
[lkml]   [2007]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] FUTEX : new PRIVATE futexes
    On Fri, 6 Apr 2007, Nick Piggin wrote:
    >
    > I like |= for adding flags, it seems less ambiguous. But I guess that's
    > a matter of opinion. Hugh seems to like +=,

    Do I? You probably have a shaming example in mind (PAGE_MAPPING_ANON?
    that's a hybrid case where using + and - helped minimize the casting);
    but in general I'd agree with you that it's |= for setting flag bits.

    Hmm, Eric's FUT_OFF_INODE is hybrid too, that might justify the +=

    > and I can't argue with him about style issues ;)

    I feel a warm glow. Nobody ever called me a style guru before.

    Hugh

    p.s. Please don't interpret this as any useful contribution to
    reviewing Eric's futex work: seems sensible, but I've hardly looked.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-06 08:09    [W:0.021 / U:0.432 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site