lkml.org 
[lkml]   [2007]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/8] Make process freezer reentrant
    On 04/02, Gautham R Shenoy wrote:
    >
    > int freeze_processes(unsigned long freeze_event)
    > {
    > unsigned int nr_unfrozen;
    > -
    > + int ret = 0;
    > + mutex_lock(&freezer_mutex);
    > + if (system_freeze_event_mask & freeze_event)
    > + goto done;

    I am not sure this is correct. Suppose that system_freeze_event_mask == FE_SUSPEND,
    now freeze_processes(FE_ALL) returns success. Shouldn't we return an error?

    Oleg.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-05 11:55    [W:0.021 / U:31.080 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site