lkml.org 
[lkml]   [2007]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 12/14] get_unmapped_area handles MAP_FIXED in /dev/mem (nommu)
From
Date
On Wed, 2007-04-04 at 11:31 +0100, David Howells wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > + if (flags & MAP_FIXED)
> > + if ((addr >> PAGE_SHIFT) != pgoff)
> > + return (unsigned long) -EINVAL;
>
> Again... in NOMMU-mode there is no MAP_FIXED - it's rejected before we get
> this far.
>
> > - return pgoff;
> > + return pgoff << PAGE_SHIFT;
>
> That, however, does appear to be a genuine bugfix.

I'll separate it from the rest of the patches

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-05 01:17    [W:0.144 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site