Messages in this thread |  | | | Subject | Re: [PATCH 11/14] get_unmapped_area handles MAP_FIXED on ramfs (nommu) | | From | Benjamin Herrenschmidt <> | | Date | Thu, 05 Apr 2007 09:13:52 +1000 |
| |
On Wed, 2007-04-04 at 11:16 +0100, David Howells wrote: > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > > > - if (!(flags & MAP_SHARED)) > > + /* Deal with MAP_FIXED differently ? Forbid it ? Need help from some nommu > > + * folks there... --BenH. > > + */ > > + if ((flags & MAP_FIXED) || !(flags & MAP_SHARED)) > > MAP_FIXED on NOMMU? Surely you jest...
Heh, see the comment, I was actually wondering about it :-)
> See the first if-statement in validate_mmap_request(). > > If anything, you should be adding BUG_ON(flags & MAP_FIXED).
Yeah, I missed that bit. That will simplify the problem.
Thanks, Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |