lkml.org 
[lkml]   [2007]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[1/6] make stack size configurable (was: Re: [-mm patch] i386: enable 4k stacks by default)
On Mon, Apr 30, 2007 at 10:38:19AM -0700, William Lee Irwin III wrote:
> Here's what I did for i386 for someone concerned about blowing the stack.

Make more stack sizes configurable, adding options for deeper stacks.
This is largely for differential diagnosis in cases where stack overflows
are suspected of silently corrupting memory or causing other problems not
detected immediately.

Signed-off-by: William Irwin <wli@holomorphy.com>


Index: stack-paranoia/arch/i386/Kconfig.debug
===================================================================
--- stack-paranoia.orig/arch/i386/Kconfig.debug 2007-04-30 10:26:15.863869853 -0700
+++ stack-paranoia/arch/i386/Kconfig.debug 2007-04-30 10:31:43.878562345 -0700
@@ -56,6 +56,10 @@
portion of the kernel code won't be covered by a 2MB TLB anymore.
If in doubt, say "N".

+choice
+ prompt "Stack size"
+ default 8KSTACKS
+
config 4KSTACKS
bool "Use 4Kb for kernel stacks instead of 8Kb"
depends on DEBUG_KERNEL
@@ -66,6 +70,37 @@
on the VM subsystem for higher order allocations. This option
will also use IRQ stacks to compensate for the reduced stackspace.

+config 8KSTACKS
+ bool "Use 8KB for kernel stacks"
+ help
+ If you say Y here, the kernel will use its standard stacksize.
+
+config 16KSTACKS
+ bool "Use 16KB for kernel stacks"
+ help
+ If you say Y here, the kernel will use a 16KB stacksize.
+ This impedes running more threads on a system and also increases
+ the pressure on the VM subsystem for higher order allocations.
+ This option will also use IRQ stacks to for additional safety.
+
+config 32KSTACKS
+ bool "Use 32KB for kernel stacks"
+ help
+ If you say Y here, the kernel will use a 32KB stacksize.
+ This impedes running more threads on a system and also increases
+ the pressure on the VM subsystem for higher order allocations.
+ This option will also use IRQ stacks to for additional safety.
+
+config 64KSTACKS
+ bool "Use 64KB for kernel stacks"
+ help
+ If you say Y here, the kernel will use a 64KB stacksize.
+ This impedes running more threads on a system and also increases
+ the pressure on the VM subsystem for higher order allocations.
+ This option will also use IRQ stacks to for additional safety.
+
+endchoice
+
config X86_FIND_SMP_CONFIG
bool
depends on X86_LOCAL_APIC || X86_VOYAGER
Index: stack-paranoia/include/asm-i386/module.h
===================================================================
--- stack-paranoia.orig/include/asm-i386/module.h 2007-04-30 10:26:31.992788987 -0700
+++ stack-paranoia/include/asm-i386/module.h 2007-04-30 10:31:43.882562573 -0700
@@ -64,8 +64,14 @@

#ifdef CONFIG_4KSTACKS
#define MODULE_STACKSIZE "4KSTACKS "
-#else
-#define MODULE_STACKSIZE ""
+#elif defined(CONFIG_8KSTACKS)
+#define MODULE_STACKSIZE "8KSTACKS "
+#elif defined(CONFIG_16KSTACKS)
+#define MODULE_STACKSIZE "16KSTACKS "
+#elif defined(CONFIG_32KSTACKS)
+#define MODULE_STACKSIZE "32KSTACKS "
+#elif defined(CONFIG_64KSTACKS)
+#define MODULE_STACKSIZE "64KSTACKS "
#endif

#define MODULE_ARCH_VERMAGIC MODULE_PROC_FAMILY MODULE_STACKSIZE
Index: stack-paranoia/include/asm-i386/thread_info.h
===================================================================
--- stack-paranoia.orig/include/asm-i386/thread_info.h 2007-04-30 10:26:32.104795370 -0700
+++ stack-paranoia/include/asm-i386/thread_info.h 2007-04-30 10:31:43.882562573 -0700
@@ -54,9 +54,17 @@

#define PREEMPT_ACTIVE 0x10000000
#ifdef CONFIG_4KSTACKS
-#define THREAD_SIZE (4096)
-#else
+#define THREAD_SIZE (4096)
+#elif defined(CONFIG_8KSTACKS)
#define THREAD_SIZE (8192)
+#elif defined(CONFIG_16KSTACKS)
+#define THREAD_SIZE (16384)
+#elif defined(CONFIG_32KSTACKS)
+#define THREAD_SIZE (32768)
+#elif defined(CONFIG_64KSTACKS)
+#define THREAD_SIZE (65536)
+#else
+#error stack size unconfigured
#endif

#define STACK_WARN (THREAD_SIZE/8)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2007-04-30 19:47    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site