lkml.org 
[lkml]   [2007]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Flaws with "UIO: Add the User IO core code" (with patch)
From
Date
On Sat, 2007-04-28 at 23:03 +0200, Hans-Jürgen Koch wrote:
> Am Samstag 28 April 2007 22:24 schrieb Alan Cox:
> > > > AFAIK we don't currently have any platform that runs binaries with
> > > > different sizes of "int" but this is a) an unsigned value anyway, and b)
> > > > should be a fixed type (eg u32)
> > >
> > > I reviewed the code once more and find it OK. There is only one legal
> > > value for the parameter "count" of uio_read(), and that's sizeof(int).
> >
> > If you are a box with multiple supported binary types how big is an
> > "int". We use explicit sizes to ensure that uio_read() will work when/if
> > we get platforms which support binaries with differing ideas of the size
> > of "int". Thus it should use s32 or s64 or similar.
>
> Here's a fix to that effect:

Can you please add a matching paragraph to the documentation ?

tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-28 23:09    [W:0.046 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site