Messages in this thread | | | Date | Sat, 28 Apr 2007 07:46:26 -0700 | From | William Lee Irwin III <> | Subject | Re: [PATCH] hugetlbfs: fix error path in module_init |
| |
On Sat, Apr 28, 2007 at 11:44:43AM +0400, Alexey Dobriyan wrote: > On 4/28/07, Akinobu Mita <akinobu.mita@gmail.com> wrote: > >init_hugetlbfs_fs() needs to unregister hugetlbfs > >when kern_mount() returns error. > HUGETLBFS is bool, so __init function should panic more and > __exit function should be removed. Or someone is planning > making it tristate?
It'd be nice for it to be normal enough to go tristate, but there isn't going to be any effort expended directly to that end. Might as well remove the exit function. Probably mostly pointless to try to avoid panicking, but I'd not bother with new panics as a simplification just because panicking is somewhat rude.
- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |