![]() | |||||||||||||
Messages in this thread |
Hi Jiri, On Sat, 28 Apr 2007, Jiri Kosina wrote: > Paul, do you have any idea? In fact, what was your reason for putting this > WARN_ON() there? The static quirk list uses idVendor == 0 to mark the end of hid_blacklist[], so we don't expect any device to have idVendor == 0. If a device is correctly presenting with idVendor == 0, we need a different way to terminate that blacklist. Either that or there's an upper-layer bug, as you write. Regarding its placement: that WARN_ON() belongs in the static quirk lookup code, rather than where it is now. Its current location must be a relic of an earlier patchset. > Did you ever meet any condition when idVendor == 0 appears there? No. There shouldn't be any functional problem with removing that WARN_ON(), and also removing the initial if() in usbhid_lookup_dquirk(). - Paul - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-04-28 01:27 [from the cache] ©2003-2008 | |||||||||||||